Skip to content

Update keybindings similar to MilkDrop #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shubhamrajeevpunekar
Copy link
Contributor

No description provided.

revmischa and others added 30 commits June 17, 2018 13:52
- HLSL: Lots of HLSLparser fixes
- HLSL: Add Preprocessor macro support
- HLSL: Add functions: modf, tan
- HLSL: Add while loops support
- Shader static code fixes
- Add define DUMP_SHADERS_ON_ERROR
- ShaderEngine.hpp cleanup
- Restore current preset message
- Remove useless messages
Plugins should be unversioned shared objects
Add --disable-rpath switch to avoid hardcoded path
Also install icon file mentioned in the .desktop
Delete backup file otherwise it will get installed along with everything else
- fake audio
- unlock FPS (linux only)
Renderer target rewrite to remove FBO support (better fps)
Render to texture support restored
mancoast and others added 23 commits July 7, 2019 19:25
* use travis to select clang/gcc, upgrade xcode

* where does this go

* where does this go

*             - libc++-dev

* bleh

* config

* test

* enable SDL for all travis builds (because -test depends on it)

* libsdl2 dep

*       - libc++-dev dep
…onsive. fix fullscreen->windowed. add ctl-q to quit.
…ndom textures (projectM-visualizer#239)

* There was a bug that existed in open GL ES 2.0 implementations
where glTexImage2D could not convert GL_RGB formed textures into GL_RGBA
while generating the noise textures.   The GL error
was GL_INVALID_OPERATION(0x502)
This probably made the noise textures blank.
So a new class was added that has the alpha channel for the values.

* Added a fudge for render farming milkdrop where we control the time and the ticks.

* User defined time: Got rid of testing code

* Attempt to fix WIN32 compile - it doesnt use or need the ability to control the time

* Got rid of debug - got rid of minor warning

* projectM.hpp - type in ifdef
projectM_SDL_main.cpp - there is code added to make the initial random number dependent on the time of day, making
the sequence of visualizers more unexpected.  But the posix command time does not exist in Win32 land, so we disable it.
* autogen.sh: add more portable #!, provide -e key explicitly

This is minority, NixOS and some other distros do not have this `sh`,
paradoxically `/usr/bin/env` path is more widespread.

Also documenting `set -e`

* autogen.sh: upd output, make it portable

`echo` has different behaviour, keys and possibilities on different systems.
Example:
```
echo "Line1\nLine2"
```

Is probably parses `\n` in `macOS`, while Linux `echo` didn't, resulting
in verbatim line.

`printf` special character parsing is much more portable.

Also removed the thanks "You followed directions! Great work!"
to the person that just ran one command, which is a script that has one command
inside and thanks the person for that.
…isualizer#249)

This is intended to install the folders as deposited at the source. If the backend is used then the desired folder will be selected.

This allows a better overlay of the available presets and avoids overwriting the same filenames in different folders during installation.

New configure value "--enable-preset-subdirs"
* BUILDING.md: rm tautology & move phrase to relevant place

* BUILDING.md: mv place build info after dependency info & add subsection

`autogen.sh` is in strange state, it consists only of `autoreconf --install`,
and thanks for doing everything right. Also it spews `\n` verbatim,
because person was writing/testing it on mac. Standartizing it in later proposal.

* BUILDING.md: upd deps info to universal documentaion

It is impossible to provide&keep the deps list/names for all OSes.

Also different `configure` options require different dependencies provided.

To provide the main documentation on why and what is needed is more important
then a bunch of partial one-liner examples.

& the differences between systems and package names are minimal.

So better describe the required dependencies in terms of Debian/Ubuntu,
and allow maintainers to fiqure-out their OS-specific variants.

* BUILDING.md: Android: upd commands to be a commands block

* BUILDING.md: mv Windows down, to logically group all *nix info

* BUILDING.md: mv sec Additional info on deps to be after main info on deps

* BUILDING.md: upd text properly outlining command & lib names

* BUILDING.md: Deps: Jack: add mention of libqt5opengl5

Since it uses Qt, so also `libqt5opengl5`.

* BUILDING.md: Additonal info: upd libglm

Co-Authored-By: Mischa Spiegelmock <[email protected]>

* BUILDING.md: Building: upd ./configure comments

Co-Authored-By: Mischa Spiegelmock <[email protected]>
* Reduce Qt5 requirements to a minimum

* Extend the search path for Qt-related tools
1. Updated keybinding for previous preset to BACKSPACE
2. Updated keybinding for hard cut next preset to H
@ghost
Copy link

ghost commented Nov 4, 2019

Greetings @srp3003

Can you review to verify that your implementation matches the classic milkdrop keybindings?

image

@@ -169,7 +169,7 @@ void projectM::default_key_handler( projectMEvent event, projectMKeycode keycode
break;
case PROJECTM_K_b:
break;
case PROJECTM_K_n:
case PROJECTM_K_H:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep both?

@revmischa
Copy link
Collaborator

opened in favor of #279

@revmischa revmischa closed this Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.